Skip to content

Commit

Permalink
clearer comment about values being loaded by get_state
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Jul 30, 2024
1 parent 10ba1fb commit d4c2308
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion kubespawner/spawner.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,14 @@ def __init__(self, *args, **kwargs):
# By now, all the traitlets have been set, so we can use them to
# compute other attributes

# namespace, pod_name, dns_name are persisted in state
# namespace, pod_name, etc. are persisted in state
# so values set here are only _default_ values.
# If this Spawner has ever launched before,
# these values will be be overridden in `get_state()`
#
# these same assignments should match clear_state
# for transitive values (pod_name, dns_name)
# but not persistent values (namespace, pvc_name)
if self.enable_user_namespaces:
self.namespace = self._expand_user_properties(
self.user_namespace_template, slug_scheme="safe"
Expand Down

0 comments on commit d4c2308

Please sign in to comment.