Fix constants/gets not working within a Provider #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
approved these changes
Jul 22, 2023
gdotdesign
approved these changes
Jul 22, 2023
|
Nice, thank you very much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned within #619 (comment), this PR fixes a couple of issues with both constants and gets when using them with a Provider:
VariableMissingerror)I've done a quick test in browser and the above seems to be working there too 😄 Unfortunately none of the existing providers use these features yet - perhaps some
.minttests purely for testing language features rather than the standard library might be useful?I'll update the other PR to support Providers once this is merged 👍