Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backward compatible serde for mongo cache #73

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pkg/mdb2/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package mdb2

import (
"fmt"
"go.mongodb.org/mongo-driver/bson/bsoncodec"
"io/ioutil"
"os"
"runtime"
Expand All @@ -19,14 +20,18 @@ type cache struct {
sync.Mutex
}

func newCache(mdb *Mdb) (*cache, error) {
var codecRegistry *bsoncodec.Registry

func newCache(mdb *Mdb, registry *bsoncodec.Registry) (*cache, error) {
if err := os.MkdirAll(mdb.cacheDir, os.ModePerm); err != nil {
return nil, err
}
c := &cache{
m: make(map[string]*cacheItem),
mdb: mdb,
}

codecRegistry = registry
c.init()
return c, nil
}
Expand Down Expand Up @@ -56,7 +61,7 @@ func (c *cache) init() {
}
// deserialize to get Id in appropriate type
o := &obj{}
if err := bson.Unmarshal(raw, o); err == nil {
if err := bson.UnmarshalWithRegistry(codecRegistry, raw, o); err == nil {
id = o.Id
}

Expand Down Expand Up @@ -126,15 +131,15 @@ func (c *cache) purge() {
delete(c.m, k)
c.Unlock()
err := c.mdb.saveId(i.col, "saveId", i.id, i.o())
if err != nil {
if err != nil && !IsUnackWrite(err) {
log.S("col", i.col).S("id", fmt.Sprintf("%v", i.id)).Error(err)
}
c.Lock()
if _, found := c.m[k]; found {
c.Unlock()
continue
}
if err == nil {
if err == nil || IsUnackWrite(err) {
// remove from disk
err2 := os.Remove(i.fn)
if err2 != nil {
Expand Down Expand Up @@ -175,5 +180,5 @@ func (i *cacheItem) o() *bson.Raw {
}

func (i *cacheItem) unmarshal(o interface{}) error {
return bson.Unmarshal(i.raw, o)
return bson.UnmarshalWithRegistry(codecRegistry, i.raw, o)
}
14 changes: 13 additions & 1 deletion pkg/mdb2/mdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"context"
"errors"
"fmt"
"go.mongodb.org/mongo-driver/x/mongo/driver"
"reflect"
"strings"
"text/template"
Expand Down Expand Up @@ -219,7 +220,7 @@ func (mdb *Mdb) Init(connStr string, opts ...func(db *Mdb)) error {
}

if mdb.cacheDir != "" {
mdb.cache, err = newCache(mdb)
mdb.cache, err = newCache(mdb, reg)
if err != nil {
return err
}
Expand Down Expand Up @@ -548,3 +549,14 @@ func IsDup(err error) bool {
}
return false
}

// IsUnackWrite checks if error is unacknowledged write error
func IsUnackWrite(err error) bool {
if err == nil {
return false
}

return errors.Is(err, mongo.ErrUnacknowledgedWrite) ||
errors.Is(err, driver.ErrUnacknowledgedWrite) ||
err.Error() == mongo.ErrUnacknowledgedWrite.Error()
}
34 changes: 32 additions & 2 deletions pkg/mdb2/mdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/gob"
"encoding/json"
"fmt"
"go.mongodb.org/mongo-driver/bson"
"io/ioutil"
"os"
"reflect"
Expand Down Expand Up @@ -57,7 +58,7 @@ var testCacheDir = "./tmp/cacheDir"

func TestCacheAdd(t *testing.T) {
db := &Mdb{name: "dbName", cacheDir: testCacheDir}
c, err := newCache(db)
c, err := newCache(db, bson.DefaultRegistry)
assert.Nil(t, err)

err = c.add("obj", 1, &obj{Id: 1})
Expand All @@ -71,7 +72,7 @@ func TestCacheAdd(t *testing.T) {
assert.Equal(t, []string{"obj.1", "obj.2", "obj.3"}, ls)
t.Logf("%v", ls)

c2, err := newCache(db)
c2, err := newCache(db, bson.DefaultRegistry)
assert.Nil(t, err)
assert.Len(t, c2.m, 3)

Expand Down Expand Up @@ -166,3 +167,32 @@ func TestMongoSerde(t *testing.T) {
assert.Equal(t, int(m["b"].(map[string]interface{})["i32"].(int32)), res["b"].(map[string]interface{})["i32"])
assert.Equal(t, int64(m["c"].(int)), res["c"])
}

func TestMongoCacheSerde(t *testing.T) {
db := &db2{}
if err := db.Init(DefaultConnStr(), Name(testDbName), CacheRoot("./tmp/tests/cache")); err != nil {
log.Fatalf("failed to open connection: %s", err)
return
}
m := map[string]interface{}{
"a": 12345,
"b": map[string]interface{}{
"i": 12345678901235,
"i64": int64(12345678901235),
"i32": int32(1234567),
},
"c": 12345678901234,
}
db.SaveId(testCollectionName, 2513, m)

var res map[string]interface{}
db.ReadId(testCollectionName, 2513, &res)

assert.Equal(t, m["a"], res["a"])
assert.Equal(t, int64(m["b"].(map[string]interface{})["i"].(int)), res["b"].(map[string]interface{})["i"])
assert.Equal(t, m["b"].(map[string]interface{})["i64"].(int64), res["b"].(map[string]interface{})["i64"])
assert.Equal(t, int(m["b"].(map[string]interface{})["i32"].(int32)), res["b"].(map[string]interface{})["i32"])
assert.Equal(t, int64(m["c"].(int)), res["c"])

db.cache.purge()
}