-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search and sorting OOIs #3262
Search and sorting OOIs #3262
Conversation
Co-authored-by: Jan Klopper <janklopper+underdark@gmail.com>
…rdination into feature/search
Did a small QA so I could test #3320, I love this feature, it will make the end-users life so much easier ❤️!
This will make it easier for user to quickly search through the data, instead of having to open de filter selection dropdown, scroll down and then click on the apply button. My preference would be to move the search bar out of the filter section completely and even place it above this section. This will really improve the user experience. |
closes #345 |
Sorting is applied in #3320 |
…n into feature/search
1: Yes, fully agree with this request. We're currently working towards the new filters design. Which removes the need to always open the filters as it is now. An example of the new design to give an idea of the direction we're going in: For the object page (and other tables that need to be filterable) we will have the same setup. If we also want to include a filter option at the top of the page will depend on the content of the page. As the filter options will be used for specific content. I can see situations where it would be useful to set filters for all the content on the page (e.g dashboard). But in most situations we will place the filters within the section it belongs to. For example, above any (large) table that needs to be filterable. Which will also leaves us the possibility to add a KAT-wide search bar in the future. For example in the header. |
This will be a great improvement! Already looking forward to this. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny remark about a type; should be an easy fix
Co-authored-by: Jeroen Dekkers <jeroen@dekkers.ch>
…rdination into feature/search
Checklist for QA:
What works:Looks good. Searching on 'mis' will give all mispo.es results. This will definitely make life easier. What doesn't work:n/a Bug or feature?:n/a |
Changes
Adds a substring search to the OOI list.
Adds sorting in OOI list on
object_type
orscan_level
Issue link
Closes #345
Part of #3084
Demo
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.