Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/ooi details #3275

Merged
merged 16 commits into from
Jul 29, 2024
Merged

Refactor/ooi details #3275

merged 16 commits into from
Jul 29, 2024

Conversation

underdarknl
Copy link
Contributor

Changes

move to a Dict based return for the OOI-refrences etc.

Issue link

related to earlier refactor work.

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.

QA notes

Please add some information for QA on how to test the newly created code.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

ammar92
ammar92 reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

rocky/rocky/views/mixins.py Outdated Show resolved Hide resolved
@underdarknl underdarknl changed the title Refactor/ooi detalis Refactor/ooi details Jul 23, 2024
@underdarknl underdarknl marked this pull request as ready for review July 23, 2024 15:04
@underdarknl underdarknl requested a review from a team as a code owner July 23, 2024 15:04
ammar92
ammar92 previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark/ suggestion; looks good otherwise

rocky/rocky/views/mixins.py Outdated Show resolved Hide resolved
@dekkers dekkers merged commit 7cb2c5e into main Jul 29, 2024
10 checks passed
@dekkers dekkers deleted the refactor/ooi-detalis branch July 29, 2024 08:18
jpbruinsslot added a commit that referenced this pull request Jul 29, 2024
@jpbruinsslot
Merge branch 'feature/mula/storage-updates' into feature/mula/refacto…
ff49bc5 
…r-queue

* feature/mula/storage-updates:
  Fix tests
  Update
  Update tests
  Fix mypy suggestions
  Refactor/ooi details (#3275)
  Raise Timeout Exception when only timeouts from DNS server (#3264)
  Fix broken token auth when 2FA is enabled (#3260)
  Restructure storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers approved these changes

@ammar92 ammar92 ammar92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underdarknl @dekkers @ammar92