Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default tests for loaders #186

Merged
merged 10 commits into from
Mar 6, 2020
Merged

Add default tests for loaders #186

merged 10 commits into from
Mar 6, 2020

Conversation

rabitt
Copy link
Collaborator

@rabitt rabitt commented Mar 6, 2020

Fixes #162

@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #186 into master will decrease coverage by 3.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   98.38%   94.81%   -3.57%     
==========================================
  Files          18       18              
  Lines        1852     1852              
==========================================
- Hits         1822     1756      -66     
- Misses         30       96      +66

@rabitt rabitt changed the title [WIP] Add default tests for loaders Add default tests for loaders Mar 6, 2020
@rabitt rabitt requested a review from lostanlen March 6, 2020 01:27
lostanlen
lostanlen reviewed Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. i'm a little uncertain about the star import, but i guess that it's a small price to pay in the face of the benefit of being able to iterate over datasets.
how does this PR interact with #176 ?

mirdata/__init__.py Show resolved Hide resolved
mirdata/__init__.py Outdated Show resolved Hide resolved
tests/test_loaders.py Show resolved Hide resolved
Vincent Lostanlen added 2 commits March 5, 2020 21:40
@rabitt rabitt merged commit e57072a into master Mar 6, 2020
@lostanlen lostanlen deleted the rachel/default_tests branch March 7, 2020 14:18
@rabitt rabitt mentioned this pull request Apr 3, 2020
Closed
nkundiushuti pushed a commit that referenced this pull request Nov 4, 2020
@rabitt
810e23f 
 
Add default tests for loaders (#186)

* add __all__

* add default tests for all modules in __all__

* remove unused tests, run black

* remove redundant tests

* run black

* whoops

* remove from . import *

after consensus with rabitt

* spurious empty line in __init__

Co-authored-by: Rachel Bittner <rachelbittner@spotify.com>
Co-authored-by: Vincent Lostanlen <vincent.lostanlen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostanlen lostanlen lostanlen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-generated test template
2 participants
@rabitt @lostanlen