Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing #198

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Update contributing #198

merged 9 commits into from
Apr 1, 2020

Conversation

magdalenafuentes
Copy link
Collaborator

  • Update contributing with updated checklist and contribution policy
  • Add table with currently supported datasets and refactor minor things in README.md
  • Fix TypeERROR message jams_utils.py

@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #198 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          18       18           
  Lines        1938     1938           
=======================================
  Hits         1858     1858           
  Misses         80       80

rabitt
rabitt reviewed Apr 1, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
lostanlen
lostanlen reviewed Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the spelling of Medley-solos-DB

README.md Outdated Show resolved Hide resolved
lostanlen
lostanlen requested changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear what "make sure" means. What do i do if the dataset doesn't appear there?

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
mirdata/jams_utils.py Show resolved Hide resolved
lostanlen
lostanlen approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostanlen lostanlen merged commit 19ec819 into master Apr 1, 2020
This was referenced Apr 3, 2020
Closed
Closed
@rabitt rabitt deleted the update_contributing branch April 7, 2020 11:13
nkundiushuti pushed a commit that referenced this pull request Nov 4, 2020
@magdalenafuentes
71a644e 
 
Update contributing with updated checklist and contribution policy (#198)

* Update CONTRIBUTING.md

* Add currently supported datasets to README.md and refactor

* Add reference in beatles.py

* Fix message TypeError jams_utils.py

* Fix link

* Fix name dataset

* Datasets in list and link to docs

* remove step 8 for now

* Add description checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabitt rabitt rabitt left review comments

@lostanlen lostanlen lostanlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magdalenafuentes @lostanlen @rabitt