Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MultiTrack class" #303

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Revert "MultiTrack class" #303

merged 1 commit into from
Oct 27, 2020

Conversation

rabitt
Copy link
Collaborator

@rabitt rabitt commented Oct 27, 2020

Reverts #295

@rabitt
Copy link
Collaborator Author

rabitt commented Oct 27, 2020

Reverting this - I realized the new class breaks some conventions that will make #296 more complicated. Updating it now in the original PR!

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #303 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   99.06%   99.04%   -0.02%     
==========================================
  Files          24       24              
  Lines        2561     2523      -38     
==========================================
- Hits         2537     2499      -38     
  Misses         24       24              

@rabitt rabitt merged commit 434775e into master Oct 27, 2020
nkundiushuti pushed a commit that referenced this pull request Nov 4, 2020
 
Revert "MultiTrack class (#295)" (#303)

This reverts commit ab84b06.
@rabitt rabitt deleted the revert-295-multitrack-class branch December 17, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant