-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for CompMusic Raga Dataset #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 96.67% 96.75% +0.08%
==========================================
Files 50 51 +1
Lines 6160 6313 +153
==========================================
+ Hits 5955 6108 +153
Misses 205 205 |
genisplaja
changed the title
[WIP] Adding loader for CompMusic Raga Dataset
Adding loader for CompMusic Raga Dataset
Oct 24, 2022
nkundiushuti
requested changes
Oct 27, 2022
nkundiushuti
approved these changes
Nov 7, 2022
@genisplaja small request: can you change the name of the module from |
genisplaja
force-pushed
the
indian_raga
branch
from
November 9, 2022 19:27
d538245
to
0a4371e
Compare
@magdalenafuentes done:) The part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding loader for CompMusic Raga Dataset
Description
Please include the following information at the top-level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset (ongoing, it takes a while)At the moment there is no Zenodo entry for this dataset. We will create it soon, separating the audio (which must be restricted) and the annotations/features (which are open).