Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding loader for (CompMusic) Hindustani Music Rhythm #566

Merged
merged 13 commits into from
Nov 22, 2022
Merged

Conversation

genisplaja
Copy link
Collaborator

@genisplaja genisplaja commented Nov 21, 2022

Adding loader for (CompMusic) Hindustani Music Rhythm

Description

Please include the following information at the top level docstring for the dataset's module mydataset.py:

  • Describe annotations included in the dataset
  • Indicate the size of the datasets (e.g. number files and duration, hours)
  • Mention the origin of the dataset (e.g. creator, institution)
  • Describe the type of music included in the dataset
  • Indicate any relevant papers related to the dataset
  • Include a description about how the data can be accessed and the license it uses (if applicable)

Dataset loaders checklist:

  • Create a script in scripts/, e.g. make_my_dataset_index.py, which generates an index file.
  • Run the script on the canonical version of the dataset and save the index in mirdata/indexes/ e.g. my_dataset_index.json.
  • Create a module in mirdata, e.g. mirdata/my_dataset.py
  • Create tests for your loader in tests/datasets/, e.g. test_my_dataset.py
  • Add your module to docs/source/mirdata.rst and docs/source/table.rst
  • Run tests/test_full_dataset.py on your dataset.

@nkundiushuti nkundiushuti self-requested a review November 21, 2022 14:57
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #566 (45fa602) into master (2170a33) will decrease coverage by 0.00%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   96.80%   96.79%   -0.01%     
==========================================
  Files          52       53       +1     
  Lines        6379     6499     +120     
==========================================
+ Hits         6175     6291     +116     
- Misses        204      208       +4     

@genisplaja genisplaja merged commit c8865cb into master Nov 22, 2022
@genisplaja genisplaja deleted the genis/hmr branch November 22, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants