-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
580 mirdata multiple fixes #581
580 mirdata multiple fixes #581
Conversation
Discussion: #580 |
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 96.85% 96.84% -0.01%
==========================================
Files 55 56 +1
Lines 6705 6717 +12
==========================================
+ Hits 6494 6505 +11
- Misses 211 212 +1 |
I think that looks good! Thanks @guillemcortes :) That would fix what we discussed last week. What do you guys think @harshpalan, @magdalenafuentes, @nkundiushuti? Should we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @guillemcortes and @genisplaja. This looks good. I'll approve the changes and we can merge them. Thanks :)
Addressing #580