Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

580 mirdata multiple fixes #581

Merged
merged 7 commits into from
Mar 7, 2023
Merged

580 mirdata multiple fixes #581

merged 7 commits into from
Mar 7, 2023

Conversation

@guillemcortes
Copy link
Collaborator Author

Discussion: #580

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #581 (6c5a1c8) into master (c9fd249) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   96.85%   96.84%   -0.01%     
==========================================
  Files          55       56       +1     
  Lines        6705     6717      +12     
==========================================
+ Hits         6494     6505      +11     
- Misses        211      212       +1     

@genisplaja
Copy link
Collaborator

I think that looks good! Thanks @guillemcortes :) That would fix what we discussed last week. What do you guys think @harshpalan, @magdalenafuentes, @nkundiushuti? Should we merge?

Copy link
Collaborator

@harshpalan harshpalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @guillemcortes and @genisplaja. This looks good. I'll approve the changes and we can merge them. Thanks :)

@genisplaja genisplaja merged commit 0620b8c into mir-dataset-loaders:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants