GitHub Actions migration #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 96.96% 97.00% +0.04%
==========================================
Files 58 58
Lines 6990 6987 -3
==========================================
Hits 6778 6778
+ Misses 212 209 -3 |
guillemcortes
force-pushed
the
guillem/ghactions_migration
branch
from
ac07a11
to
e5b46d0
Compare
The motivation of this change is that linux and macos return different floats. MacOS returns 260.946404518887 while Linux 260.94640451888694. So we adjust the tolerance of the test
15 tasks
added 12 commits
October 27, 2023 12:38
This comment was showing the assertion test done before the PR#596
genisplaja
approved these changes
Oct 27, 2023
guillemcortes
changed the title
guillemcortes
added a commit
that referenced
this pull request
Nov 2, 2023
* idmt_smt_audio_effects dataset script and index * idmt_smt_audio_effects loader * idmt_smt_audio_effects tests and resources * idmt_smt_audio_effects dataset added to docs * black formatter * fixing type error in mypy test * loader docstring * pytest fix: folder delete in dataloader * remove download func, adding unpacking dirs * fixed resources path * formatting * formatting * added tests * added tests * fixing test * fix dependencies in setup.py * modified dataset tests and added custom track to test_loaders.py * changed docstrings and exception handling * docstrings * GitHub Actions migration (#596) * ADD formatting workflow * FIX variables in formatting workflow * ADD python linting workflow and environment * ADD CI workflow and environment * Remove CircleCI * UPDATE new_loader.md PR template * ADD readthedocs * UPDATE readme badges * FIX numpy asarray bug * CHANGE arg name due to librosa update * REMOVE tox.ini * UPDATE dependencies for test * ADD dependencies * dependencies.. * dependencies.. * dependencies.. * dependencies.. * fix dependencies versions * ADD all smart_open protocols install for CI * MOVE smart_open[all] to pip install * INSTALL types to pass mypy * intall types-pyaml for python linting test * Change to work with music21 v9.* * TEST Environment CI with no reestrictions. python3.10 test passing in local * FIX ikala test to pass linux tests * FIX normpath for windows tests * BLACK * Change assert tolerance for floats in test_ikala The motivation of this change is that linux and macos return different floats. MacOS returns 260.946404518887 while Linux 260.94640451888694. So we adjust the tolerance of the test * Remove windows CI test * Assert modification forgot in the last commit * Specifying packages versinos on environment yml * Fix h5py version for python3.7 * CI test dependencies fixed at the versions of last passing test * CI test dependencies without lowerbound * CI test dependencies that should work * sort dependencies by alphabetical order * Update setup dependencies * Update test-lint dependencies * Update contributing docs to match new testing pipeline * Remove comment from test_ikala This comment was showing the assertion test done before the PR#596 * Set dependencies packages versions for docs * Remove comment * jams get_duration handling * Trigger tests after CircleCI removing --------- Co-authored-by: Magdalena Fuentes <mgfuenteslujambio@gmail.com> * Update badges url (#598) * Update badges url * Trigger doc build again * metadata exception, whitespaces in table.rst * fixing table.rst * fixing mirdata.rst and adding references to quick_reference.rst * increasing test coverage * adding corrupted xml file for testing * modified metadata logic for xml files * removed general exception * removing FileNotFoundError, changing dirs for _ and moving Cached Properties to Attributes * revert to FileNotFoundError and test --------- Co-authored-by: Magdalena Fuentes <mgfuenteslujambio@gmail.com> Co-authored-by: Genís Plaja-Roglans <genis.plaja@upf.edu> Co-authored-by: Guillem Cortès <cortes.sebastia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list: