Fix tests on Windows #251
Merged
Fix tests on Windows #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't use a Unix domain socket there, so use TCP on 127.0.0.1 instead. Also, report `Closed` for `Unix.ECONNRESET` too to avoid an unnecessary warning.
Closed
|
I've added support for Unix domain sockets on Windows in OCaml 4.14, but I would try to use one for standard input/output. Could be interesting to use capnp to test the support further. |
On Windows, the "Broken ref" test was failing with:
Failure "recv: Unix.Unix_error(Unix.ECONNRESET, \"write\", \"\")"
On Windows, it seems that we see the connection close immediately, without first reading the goodbye message.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Feb 23, 2023
…age and capnp-rpc-lwt (1.2.3) CHANGES: - Update to cmdliner 1.1.0 (@MisterDA mirage/capnp-rpc#249). - Fix tests on Windows, avoid using Unix domain sockets (@talex5 mirage/capnp-rpc#251). - Fix warning on `Unix.ENOTCONN` under macos (@talex5 mirage/capnp-rpc#252). - Add `Capnp_rpc_unix.Cap_file.save_uri` (@talex5 mirage/capnp-rpc#253). - Update README to use MDX (@talex5 mirage/capnp-rpc#254). - Update tests to Cap'n Proto 0.10.3 (@MisterDA mirage/capnp-rpc#257 mirage/capnp-rpc#260). - Update to mirage-crypto-rng 0.11 and dns 7.0.0 API changes (@hannesm mirage/capnp-rpc#261). - Update for opam 2.1+ installations (@frumioj mirage/capnp-rpc#259). - Install Cap'n Proto binaries in Windows GHA (@MisterDA mirage/capnp-rpc#248).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Feb 23, 2023
…age and capnp-rpc-lwt (1.2.3) CHANGES: - Update to cmdliner 1.1.0 (@MisterDA mirage/capnp-rpc#249). - Fix tests on Windows, avoid using Unix domain sockets (@talex5 mirage/capnp-rpc#251). - Fix warning on `Unix.ENOTCONN` under macos (@talex5 mirage/capnp-rpc#252). - Add `Capnp_rpc_unix.Cap_file.save_uri` (@talex5 mirage/capnp-rpc#253). - Update README to use MDX (@talex5 mirage/capnp-rpc#254). - Update tests to Cap'n Proto 0.10.3 (@MisterDA mirage/capnp-rpc#257 mirage/capnp-rpc#260). - Update to mirage-crypto-rng 0.11 and dns 7.0.0 API changes (@hannesm mirage/capnp-rpc#261). - Update for opam 2.1+ installations (@frumioj mirage/capnp-rpc#259). - Install Cap'n Proto binaries in Windows GHA (@MisterDA mirage/capnp-rpc#248).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use a Unix domain socket there, so use TCP on 127.0.0.1 instead. Also, report
ClosedforUnix.ECONNRESETtoo to avoid an unnecessary warning.