Update description to include SHA3 #146
Conversation
|
Hmm, according to #110 it probably makes sense to also add Keccak-256 to the README and description. |
|
Thanks, the error seems unrelated. If you want to continue to improve the |
Absolutely, I was already thinking of adding it to the older versions and skimming through the releases to see when they were added. Looks like it is easy enough since it is well documented, but I'll wait with that once this is merged so it matches the format of upstream. I'll add Keccak-256. Should I add the SHA3 variants as well or is it implied that SHA3 includes 224, 256, 384 and 512? |
(It is not an acronym and usually written using lowercase)
|
I think it's ok now, I'll cherry pick the description to opam-repository later. |
It added WHIRLPOOL in 0.7.1, SHA3 in 0.9.0 and Keccak-256 in 1.1.0, so now searching in the opam-repository for an SHA3 implementation it should turn up. Change submitted upstream: mirage/digestif#146
|
Thanks! |
CHANGES: - Update the description to include SHA3 (@Leonidas-from-XIV, mirage/digestif#146) - Add a new type `hash'`, a polymorphic variant (@reynir, @dinosaure, mirage/digestif#150) - Lint `fmt` dependency lower-bound (@reynir, mirage/digestif#152) - Add `get_into_bytes` function and a fuzzer about it (@reynir, @dinosaure, mirage/digestif#149)
It added WHIRLPOOL in 0.7.1, SHA3 in 0.9.0 and Keccak-256 in 1.1.0, so now searching in the opam-repository for an SHA3 implementation it should turn up. Change submitted upstream: mirage/digestif#146
While searching for hash libraries on OPAM I was looking for SHA3 support I couldn't find
digestifthough according to its readme (and code) it does support SHA3, so in this PR I'm adding it to the description.There is also Keccak-256, not sure if this should be mentioned given it is also missing from the README, but I am not sure how it differs from SHA3-256, so maybe someone with more knowledge can weight in.