documentation updates #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) close/shutdown is recursive (2) read/write errors do not lead to closed sockets
… that's not what e.g. ssh does
|
any chance I can get a review and merge and release (//cc @reynir)? |
reynir
reviewed
Feb 8, 2024
reynir
approved these changes
Feb 8, 2024
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 8, 2024
CHANGES: - move Mirage_flow.stats and pp_stats to Mirage_flow_combinators (mirage/mirage-flow#51 @hannesm) - improve documentation of expected semantics (when write promise is resolved, what is done to the underlying flow - addresses mirage/mirage-flow#4 @samoht), (mirage/mirage-flow#51 @reynir @dinosaure @hannesm) - add < coercion to shutdown: ``shutdown : flow -> [< `read | `write | `read_write ] -> unit Lwt.t`` (requested mirage/mirage-flow#50 @reynir, mirage/mirage-flow#52 @hannesm)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 8, 2024
CHANGES: - move Mirage_flow.stats and pp_stats to Mirage_flow_combinators (mirage/mirage-flow#51 @hannesm) - improve documentation of expected semantics (when write promise is resolved, what is done to the underlying flow - addresses mirage/mirage-flow#4 @samoht), (mirage/mirage-flow#51 @reynir @dinosaure @hannesm) - add < coercion to shutdown: ``shutdown : flow -> [< `read | `write | `read_write ] -> unit Lwt.t`` (requested mirage/mirage-flow#50 @reynir, mirage/mirage-flow#52 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, remove the Mirage_flow.stats which isn't used much...
/cc @reynir @dinosaure