Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more strict about padding #43

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Be more strict about padding #43

merged 3 commits into from
Mar 10, 2020

Conversation

dinosaure
Copy link
Member

This is want to fix #42 (cc @hannesm & @cfcs)

@dinosaure dinosaure requested a review from hannesm March 10, 2020 12:38
test/test.ml Show resolved Hide resolved
Copy link
Member

@hannesm hannesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinosaure dinosaure merged commit 6227924 into master Mar 10, 2020
@hannesm
Copy link
Member

hannesm commented Mar 13, 2020

would it be possible to cut a release since this PR has been merged now? thanks :)

@dinosaure
Copy link
Member Author

👍

dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Mar 13, 2020
CHANGES:

- Fix tests about `alcotest.1.0.0` (@dinosaure, mirage/ocaml-base64#40)
- Be more strict about padding when we decode a base64 input (@dinosaure, @hannesm, @cfcs, mirage/ocaml-base64#43)
- Remove `fmt` dependency (mirage/ocaml-base64#43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base64.decode accepts and decodes invalid data
3 participants