Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the right key for the secondary and their zone transfers #339

Merged
merged 3 commits into from
Jun 1, 2023
Merged

use the right key for the secondary and their zone transfers #339

merged 3 commits into from
Jun 1, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented May 31, 2023

reynir
reynir approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the issue we observed. The solution makes sense to me, but it was a bit hard to read due to the many shadowing and re-use of variable names. I can look at that in a follow up PR - let's merge this :)

@reynir reynir merged commit ad547fd into mirage:main Jun 1, 2023
@hannesm hannesm deleted the fix-secondary branch June 2, 2023 12:30
@hannesm hannesm restored the fix-secondary branch June 3, 2023 13:56
@hannesm hannesm mentioned this pull request Jun 13, 2023
Merged
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jun 13, 2023
@hannesm
[new release] dnssec, dns, dns-tsig, dns-stub, dns-server, dns-resolv…
abf4533 
…er, dns-mirage, dns-client, dns-client-mirage, dns-client-lwt, dns-cli and dns-certify (7.0.2)

CHANGES:

* dns-server: for secondary servers use the right zone transfers and keys, fixed
  in mirage/ocaml-dns#339 by @hannesm
* dns: add support for null record (arbitrary binary data) (mirage/ocaml-dns#338 @RyanGibb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reynir reynir reynir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesm @reynir