Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release? #2082

Closed
chrismllr opened this issue Nov 16, 2020 · 16 comments
Closed

Release? #2082

chrismllr opened this issue Nov 16, 2020 · 16 comments

Comments

@chrismllr
Copy link

Any chance for a release soon? I've got this addon-guard notification, and noticed the ember-get-config dependency version is updated to 0.3.0 on the master branch.

ember-get-config
----------------------------------------
my-app
├─┬ ember-cli-mirage
│ └── ember-get-config@0.2.4 (cacheKey: b37f276e40fd793ce66813dfb160f912, runtime: true)
├─┬ ember-cli-moment-shim
│ └── ember-get-config@0.3.0 (cacheKey: ffb52ed19a11426f4028bc2838e5cf87, runtime: true)
└─┬ ember-power-calendar-moment
  └─┬ ember-cli-moment-shim
    └── ember-get-config@0.3.0 (cacheKey: ffb52ed19a11426f4028bc2838e5cf87, runtime: true)
@samselikoff
Copy link
Collaborator

There's been some issues with the dev build that has been blocking a release: #2081 (comment)

If you are motivated + have time to help out, that would probably be the fastest way to get to the release! I'm personally focused on other things at the moment so can't help out on this.

@cah-brian-gantzler
Copy link
Collaborator

cah-brian-gantzler commented Dec 21, 2020

These above mentioned issues have been taken care of

  • the docs not working on ember-cli-mirage for master branch
  • acceptance tests not working with ember try because addon docs only supports 3+

I think we are clear to make a release. While I dont recall anything that was specifically a breaking change, I believe Sam wanted to bump the major version number if I recall

@samselikoff
Copy link
Collaborator

#2025 Think we reverted this so we need to make sure we hvaen't changed anything since. That's what the major was for.

@samselikoff
Copy link
Collaborator

Looks like we dropped node 6 and 8 in our package.json so we do need to bump.

I'll defer to @Turbo87 here.

v1.1.8...master#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L98

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 21, 2020

yep, seems reasonable :)

@samselikoff
Copy link
Collaborator

Ok yep I'd say go ahead and release and just bump to 2.0 and note why!

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 21, 2020

if you're talking to me, I don't have npm permissions 😅

@samselikoff
Copy link
Collaborator

Haha meant @cah-briangantzler because he's been kinda driving this from something he needed, but happy to add you to npm if you'd like (with no expectation of doing any maintenance work!)

@samselikoff
Copy link
Collaborator

This is you correct? https://www.npmjs.com/~turbo87

@samselikoff
Copy link
Collaborator

Figured we haven't gotten to the point of people impersonating npm users but never hurts to ask 😁

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 21, 2020

yeah, as far as I know that should be me :D

@samselikoff
Copy link
Collaborator

gotcha :) Added!

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 22, 2020

v2.0.0 is running through TravisCI now and will hopefully be available on npm soon.

turns out I probably didn't need the npm access if CI is doing the release for me 😅

@samselikoff
Copy link
Collaborator

Oh yeah - derr. That's one of the reasons I did that, so I didn't have to add people to npm 🙈 Oh well!

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 22, 2020

alright, v2.0.0 is up on npm now. closing this issue :)

@Turbo87 Turbo87 closed this as completed Dec 22, 2020
@cah-brian-gantzler
Copy link
Collaborator

Thanks for doing this. Was a little nervous to do it, first time.

I updated my app to 2.0.0 no problem.

Can not yet confirm upgrading to qunit 5 as https://github.com/san650/ember-cli-page-object needs an update as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants