-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release? #2082
Comments
There's been some issues with the dev build that has been blocking a release: #2081 (comment) If you are motivated + have time to help out, that would probably be the fastest way to get to the release! I'm personally focused on other things at the moment so can't help out on this. |
These above mentioned issues have been taken care of
I think we are clear to make a release. While I dont recall anything that was specifically a breaking change, I believe Sam wanted to bump the major version number if I recall |
#2025 Think we reverted this so we need to make sure we hvaen't changed anything since. That's what the major was for. |
Looks like we dropped node 6 and 8 in our package.json so we do need to bump. I'll defer to @Turbo87 here. v1.1.8...master#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L98 |
yep, seems reasonable :) |
Ok yep I'd say go ahead and release and just bump to 2.0 and note why! |
if you're talking to me, I don't have npm permissions 😅 |
Haha meant @cah-briangantzler because he's been kinda driving this from something he needed, but happy to add you to npm if you'd like (with no expectation of doing any maintenance work!) |
This is you correct? https://www.npmjs.com/~turbo87 |
Figured we haven't gotten to the point of people impersonating npm users but never hurts to ask 😁 |
yeah, as far as I know that should be me :D |
gotcha :) Added! |
v2.0.0 is running through TravisCI now and will hopefully be available on npm soon. turns out I probably didn't need the npm access if CI is doing the release for me 😅 |
Oh yeah - derr. That's one of the reasons I did that, so I didn't have to add people to npm 🙈 Oh well! |
alright, v2.0.0 is up on npm now. closing this issue :) |
Thanks for doing this. Was a little nervous to do it, first time. I updated my app to 2.0.0 no problem. Can not yet confirm upgrading to qunit 5 as https://github.com/san650/ember-cli-page-object needs an update as well |
Any chance for a release soon? I've got this addon-guard notification, and noticed the
ember-get-config
dependency version is updated to0.3.0
on the master branch.The text was updated successfully, but these errors were encountered: