Bump ember-cli-addon-docs to 0.10.0 #2081
Conversation
|
Another issue where ember-cli-mirage may support 2.18, but ember-cli-addon-docs does not :( |
|
Weren't you able to use a check to only run the dummy app on latest ember? |
|
That check was stopping a problem while running the tests, unfortunately if you look at the error, this is now happening at build time :( |
|
I think the "real" solution here is to make the docs site a separate app: https://ember-learn.github.io/ember-cli-addon-docs/docs/standalone-apps Here's the PR with more info: ember-learn/ember-cli-addon-docs#409 I don't have time to help out but don't think it's a good idea to cut a release with a broken build. Perhaps can ask around to see if someone with time/motivation can help out if you can't do it. |
|
This can also be solved by dropping the ember-try against 2.18 and updating the docs to say it may support 2.18 Looking at the addon-docs I would think it should be a new repo rather than a mono-repo, which means I need to create a new repo. Do you want to do that so that it can reside under miragejs? probably call it ember-cli-mirage-docs? This however will also require changing the deploy of the site for github pages, as well as other parts of the deploy. Given all the work that would need to be done to accomplish this, I would think it would be way easier to just drop the ember-try for 2.18. While it will still work for 2.18, you just wouldnt testing for it. |
|
Sounds totally reasonable to me! Feel free to drop 2.18 👍 |
|
BTW for a nested app I don't think you need a new repo. The guide says you could e.g. put it in Honestly the best long-term solution is to get rid of this docs site completely and just point Ember CLI Mirage users to miragejs.com. And add a section for any specific Ember stuff there. |
bgantzler
force-pushed
the
upgrade-addon-docs
branch
from
228f0f4 to
1aec30f
Compare
|
I have removed the 2.18, waiting for the tests to run now. I concur with moving the docs to miragejs proper, you already have a section for it pointing back to this addon docs. Not really a doc write, but you ok with me attempting to write some docs there in an effort to retire the addon docs from here? |
|
Yes! Absolutely. I would say either an Advanced guide, or just update the Ember Quickstart to have all the ember-specific stuff. |
|
Is there a way to run miragejs/site locally so that I can see what by edits look like? |
|
Yep it’s a Gatsby site so clone it then run `yarn develop`
… On Nov 30, 2020, at 12:23 PM, Brian Gantzler ***@***.***> wrote:
Is there a way to run miragejs/site locally so that I can see what by edits look like?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2081 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWJOCVZRXFQCCAS2A5AZ4DSSPIIJANCNFSM4TSOE3ZQ>.
|
|
doing that I get |
|
What version of node? |
|
was using 12.14.0, but updated to 14.15.1 and got same result |
|
Don't know off the top of my head :/ sorry. The site has been building on Netlify though https://app.netlify.com/sites/miragejs/deploys?filter=deploy+previews |
|
This past. If you could merge it, would like to see if the master branch now works on the website |
|
Ok, so the master branch on the docs site is working fine, was all addon docs causing the issue |
|
Awesome!
… On Dec 1, 2020, at 9:10 AM, Brian Gantzler ***@***.***> wrote:
Ok, so the master branch on the docs site is working fine, was all addon docs causing the issue
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
No description provided.