Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use async/await in tests #1221

Merged
merged 1 commit into from
Nov 25, 2017
Merged

refactor: use async/await in tests #1221

merged 1 commit into from
Nov 25, 2017

Conversation

geekygrappler
Copy link
Collaborator

Last part of #1206.

@geekygrappler geekygrappler changed the title refactor: use async/await refactor: use async/await in tests Nov 19, 2017
@geekygrappler
Copy link
Collaborator Author

I should probably say to save having to read #1206. This simply replaces .then callbacks with async/await.

@geekygrappler
Copy link
Collaborator Author

Hey @rwjblue I'm going to merge this at the weekend, unless you have any comments/objections.

@rwjblue
Copy link
Collaborator

rwjblue commented Nov 23, 2017

👍 seems good to me!

@geekygrappler geekygrappler merged commit 2ef1b59 into miragejs:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekygrappler @rwjblue