Fix invalid use of ES modules #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ES module spec doesn't support "optional" exports. If you try import a name from a module and that name is not exported, it's a SyntaxError. Mirage tries to import `default`, `testConfig`, and `makeServer` from the user's config, but they are treated as optional. The solution is to import the module's whole namespace (`import * as...`) and then inspect the namespace object.
|
(I'm adding an audit tool to Embroider, and any app that uses ember-cli-mirage will see a problem in their audit results due to this issue.) |
|
Makes sense - thanks for the PR Ed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ES module spec doesn't support "optional" exports. If you try to import a name from a module and that name is not exported, it's a SyntaxError.
Mirage tries to import
default,testConfig, andmakeServerfrom the user's config, but they are treated as optional.The solution is to import the module's whole namespace (
import * as...) and then inspect the namespace object.