Update mirage logging option to work with qunit5

[cah-brian-gantzler]

Fixes #2091

There were no tests for the original adding of the option, I dont see how to add tests as it not a test of the addon but how the addon works with Qunit.

• Moved the adding of the option from vendor/add-qunit-option to test-support/qunit-configuration same as qunit5 does
• Moved import of code from index.js to test-support/index.js. This means if you never import setupMirage you will never see the option added, which kinda makes sense. This also means you wont see it if you run the tests in this repo, since none of the tests import setupMirage

[cah-brian-gantzler]

What next to get this merged in?

[Turbo87]

sorry, forgot about it 😱

[Turbo87]

@cah-briangantzler I just tried this out on an app that is still using ember-qunit v4 and the checkbox is unfortunately not visible anymore. can you check if we can make this work again too?

[cah-brian-gantzler]

I updated my application to use ember-cli-mirage 2.0.0, it is still using ember-qunit ^4.6.0 and the checkbox is visible for me.

I am unable to update my application to qunit v5 as I use ember-cli-page-object and that is NOT ember-qunit 5 compatible at this time.

I did temporarily update (but did not commit) the ember-cli-mirage tests to ember-qunit 5 and the checkbox was visible and working.

[cah-brian-gantzler]

@Turbo87 Were you able to get this to work? There is a nuance I mentioned earlier, previously just including the addon added the check box to the qunit testing, even if you never imported setupMirage (and presumably created a mirage server). Where I moved it to requires you to at least import something (mostly likely setupMirage) from 'ember-cli-mirage'. That was not on purpose, it is a by product of where I moved it, but kinda makes sense, if you never import and create a server, having the checkbox does not really do anything.

Are you creating the mirage server on your own without importing setupMirage?

[Turbo87]

I think I found the issue. We were importing setupMirage() like this:

import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';

but since the urlConfig change happens in the index.js file it was never triggered. I've now changed our imports to this:

import { setupMirage } from 'ember-cli-mirage/test-support';

and now it works... 😅

[cah-brian-gantzler]

Great to hear

[pomm0]

This seems to not work when using the autostart option. Not sure how common this option is, probably not so common, since its not even documented.

Any chance to make it work via the autostart option or would you recommend using the setupMirage test helper?