Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Advise user to shutdown pretender servers #925

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

dustinfarris
Copy link
Contributor

@dustinfarris dustinfarris commented Oct 18, 2016

Updating old documentation. I'm not sure why the original docs advised running the initializer method; the startMirage function should work just fine—no helper file should be necessary.

Closes #915 (not automatically, though)

@dustinfarris dustinfarris changed the title Advise user to shutdown pretender servers [DOCS] Advise user to shutdown pretender servers Oct 18, 2016
Copy link

@robneville73 robneville73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this seems to fix the issues with having multiple pretenders running

@samselikoff
Copy link
Collaborator

The initializer method code was taken from a @rwjblue gist... Robert, is it ok to just use

import { startMirage } from 'yourapp/initializers/ember-cli-mirage'

and call it without passing in the container?

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if the mirage initializer does not need the container, then we definitely don't need to pass it in.

@samselikoff samselikoff merged commit f4fe015 into miragejs:gh-pages Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants