revert to "new FileInputStream(...)" instead of Files.newInputStream(…

……) (#34)

* revert to "new FileInputStream(...)" instead of Files.newInputStream(...)

* add todo, clean up

src/main/java/com/miraisolutions/xlconnect/Workbook.java

@@ -37,7 +37,6 @@
 import org.apache.poi.xssf.usermodel.*;
 
 import java.io.*;
-import java.nio.file.Files;
 import java.util.*;
 import java.util.function.Consumer;
 import java.util.stream.IntStream;
@@ -101,8 +100,9 @@ private Workbook(File excelFile, String password) throws IOException {
         /*
          * NOTE: We are using a FileInputStream since otherwise using 'save' multiple times would cause
          * a JVM crash as described here: https://bz.apache.org/bugzilla/show_bug.cgi?id=53515
+         * TODO once we no longer support java 8, try again to switch to Files.newInputStream(excelFile.toPath()) 
          */
-        this.workbook = WorkbookFactory.create(Files.newInputStream(excelFile.toPath()), password);
+        this.workbook = WorkbookFactory.create(new FileInputStream(excelFile), password);
         this.excelFile = excelFile;
         init();
     }
@@ -111,8 +111,9 @@ private Workbook(File excelFile) throws IOException {
         /*
          * NOTE: We are using a FileInputStream since otherwise using 'save' multiple times would cause
          * a JVM crash as described here: https://bz.apache.org/bugzilla/show_bug.cgi?id=53515
+         * TODO once we no longer support java 8, try again to switch to Files.newInputStream(excelFile.toPath()) 
          */
-        this.workbook = WorkbookFactory.create(Files.newInputStream(excelFile.toPath()));
+        this.workbook = WorkbookFactory.create(new FileInputStream(excelFile));
         this.excelFile = excelFile;
         init();
     }
@@ -727,7 +728,8 @@ public void addImage(File imageFile, String name, boolean originalSize) throws I
         CellReference bottomRight = aref.getLastCell();
 
         int imageType = getImageType(imageFile);
-        InputStream is = Files.newInputStream(imageFile.toPath());
+        // TODO once we no longer support java 8, try again to switch to Files.newInputStream(imageFile.toPath()) 
+        InputStream is = new FileInputStream(imageFile);
         byte[] bytes = IOUtils.toByteArray(is);
         int imageIndex = workbook.addPicture(bytes, imageType);
         is.close();