Skip to content

Commit

Permalink
configure, meson: rename targetos to host_os
Browse files Browse the repository at this point in the history
This variable is about the host OS, not the target.  It is used a lot
more since the Meson conversion, but the original sin dates back to 2003.
Time to fix it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Dec 31, 2023
1 parent cfc1a88 commit d0cda6f
Show file tree
Hide file tree
Showing 33 changed files with 197 additions and 197 deletions.
2 changes: 1 addition & 1 deletion accel/tcg/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ if get_option('plugins')
tcg_ss.add(files('plugin-gen.c'))
endif
tcg_ss.add(when: libdw, if_true: files('debuginfo.c'))
if targetos == 'linux'
if host_os == 'linux'
tcg_ss.add(files('perf.c'))
endif
specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_ss)
Expand Down
4 changes: 2 additions & 2 deletions backends/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ system_ss.add([files(
'confidential-guest-support.c',
), numa])

if targetos != 'windows'
if host_os != 'windows'
system_ss.add(files('rng-random.c'))
system_ss.add(files('hostmem-file.c'))
endif
if targetos == 'linux'
if host_os == 'linux'
system_ss.add(files('hostmem-memfd.c'))
endif
if keyutils.found()
Expand Down
4 changes: 2 additions & 2 deletions block/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ if get_option('parallels').allowed()
block_ss.add(files('parallels.c', 'parallels-ext.c'))
endif

if targetos == 'windows'
if host_os == 'windows'
block_ss.add(files('file-win32.c', 'win32-aio.c'))
else
block_ss.add(files('file-posix.c'), coref, iokit)
endif
block_ss.add(when: libiscsi, if_true: files('iscsi-opts.c'))
if targetos == 'linux'
if host_os == 'linux'
block_ss.add(files('nvme.c'))
endif
if get_option('replication').allowed()
Expand Down
2 changes: 1 addition & 1 deletion bsd-user/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ kvm = cc.find_library('kvm', required: true)
bsd_user_ss.add(elf, procstat, kvm)

# Pull in the OS-specific build glue, if any
subdir(targetos)
subdir(host_os)

specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
4 changes: 2 additions & 2 deletions chardev/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ chardev_ss.add(files(
'char-udp.c',
'char.c',
))
if targetos == 'windows'
if host_os == 'windows'
chardev_ss.add(files(
'char-console.c',
'char-win-stdio.c',
Expand All @@ -23,7 +23,7 @@ else
'char-fd.c',
'char-pty.c',
), util)
if targetos in ['linux', 'gnu/kfreebsd', 'freebsd', 'dragonfly']
if host_os in ['linux', 'gnu/kfreebsd', 'freebsd', 'dragonfly']
chardev_ss.add(files('char-parallel.c'))
endif
endif
Expand Down
58 changes: 29 additions & 29 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -334,30 +334,30 @@ EOF
}

if check_define __linux__ ; then
targetos=linux
host_os=linux
elif check_define _WIN32 ; then
targetos=windows
host_os=windows
elif check_define __OpenBSD__ ; then
targetos=openbsd
host_os=openbsd
elif check_define __sun__ ; then
targetos=sunos
host_os=sunos
elif check_define __HAIKU__ ; then
targetos=haiku
host_os=haiku
elif check_define __FreeBSD__ ; then
targetos=freebsd
host_os=freebsd
elif check_define __FreeBSD_kernel__ && check_define __GLIBC__; then
targetos=gnu/kfreebsd
host_os=gnu/kfreebsd
elif check_define __DragonFly__ ; then
targetos=dragonfly
host_os=dragonfly
elif check_define __NetBSD__; then
targetos=netbsd
host_os=netbsd
elif check_define __APPLE__; then
targetos=darwin
host_os=darwin
else
# This is a fatal error, but don't report it yet, because we
# might be going to just print the --help text, or it might
# be the result of a missing compiler.
targetos=bogus
host_os=bogus
fi

if test ! -z "$cpu" ; then
Expand Down Expand Up @@ -573,13 +573,13 @@ do
fi
done

if test "$targetos" = "windows" ; then
if test "$host_os" = "windows" ; then
EXESUF=".exe"
fi

meson_option_build_array() {
printf '['
(if test "$targetos" = windows; then
(if test "$host_os" = windows; then
IFS=\;
else
IFS=:
Expand Down Expand Up @@ -802,7 +802,7 @@ mak_wilds=""

if [ -n "$host_arch" ] && [ -d "$source_path/common-user/host/$host_arch" ]; then
if [ "$linux_user" != no ]; then
if [ "$targetos" = linux ]; then
if [ "$host_os" = linux ]; then
linux_user=yes
elif [ "$linux_user" = yes ]; then
error_exit "linux-user not supported on this architecture"
Expand All @@ -813,9 +813,9 @@ if [ -n "$host_arch" ] && [ -d "$source_path/common-user/host/$host_arch" ]; the
fi
if [ "$bsd_user" != no ]; then
if [ "$bsd_user" = "" ]; then
test $targetos = freebsd && bsd_user=yes
test $host_os = freebsd && bsd_user=yes
fi
if [ "$bsd_user" = yes ] && ! [ -d "$source_path/bsd-user/$targetos" ]; then
if [ "$bsd_user" = yes ] && ! [ -d "$source_path/bsd-user/$host_os" ]; then
error_exit "bsd-user not supported on this host OS"
fi
if [ "$bsd_user" = "yes" ]; then
Expand Down Expand Up @@ -998,7 +998,7 @@ if test -z "$ninja"; then
fi
fi

if test "$targetos" = "bogus"; then
if test "$host_os" = "bogus"; then
# Now that we know that we're not printing the help and that
# the compiler works (so the results of the check_defines we used
# to identify the OS are reliable), if we didn't recognize the
Expand All @@ -1007,7 +1007,7 @@ if test "$targetos" = "bogus"; then
fi

# test for any invalid configuration combinations
if test "$targetos" = "windows" && ! has "$dlltool"; then
if test "$host_os" = "windows" && ! has "$dlltool"; then
if test "$plugins" = "yes"; then
error_exit "TCG plugins requires dlltool to build on Windows platforms"
fi
Expand Down Expand Up @@ -1041,7 +1041,7 @@ static THREAD int tls_var;
int main(void) { return tls_var; }
EOF

if test "$targetos" = windows || test "$targetos" = haiku; then
if test "$host_os" = windows || test "$host_os" = haiku; then
if test "$pie" = "yes"; then
error_exit "PIE not available due to missing OS support"
fi
Expand Down Expand Up @@ -1541,8 +1541,8 @@ echo "# Automatically generated by configure - do not modify" > Makefile.prereqs

# Mac OS X ships with a broken assembler
if have_target i386-softmmu x86_64-softmmu && \
test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
test "$targetos" != "haiku" && \
test "$host_os" != "darwin" && test "$host_os" != "sunos" && \
test "$host_os" != "haiku" && \
probe_target_compiler i386-softmmu; then
subdirs="$subdirs pc-bios/optionrom"
config_mak=pc-bios/optionrom/config.mak
Expand Down Expand Up @@ -1606,7 +1606,7 @@ echo "NINJA=$ninja" >> $config_host_mak
echo "EXESUF=$EXESUF" >> $config_host_mak

# use included Linux headers for KVM architectures
if test "$targetos" = "linux" && test -n "$linux_arch"; then
if test "$host_os" = "linux" && test -n "$linux_arch"; then
symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
fi

Expand All @@ -1629,13 +1629,13 @@ echo "SRC_PATH=$source_path/contrib/plugins" >> contrib/plugins/$config_host_mak
echo "PKG_CONFIG=${pkg_config}" >> contrib/plugins/$config_host_mak
echo "CC=$cc $CPU_CFLAGS" >> contrib/plugins/$config_host_mak
echo "CFLAGS=${CFLAGS-$default_cflags} $EXTRA_CFLAGS" >> contrib/plugins/$config_host_mak
if test "$targetos" = windows; then
if test "$host_os" = windows; then
echo "DLLTOOL=$dlltool" >> contrib/plugins/$config_host_mak
fi
if test "$targetos" = darwin; then
if test "$host_os" = darwin; then
echo "CONFIG_DARWIN=y" >> contrib/plugins/$config_host_mak
fi
if test "$targetos" = windows; then
if test "$host_os" = windows; then
echo "CONFIG_WIN32=y" >> contrib/plugins/$config_host_mak
fi

Expand Down Expand Up @@ -1715,7 +1715,7 @@ if test "$skip_meson" = no; then
echo "# environment defaults, can still be overridden on " >> $cross
echo "# the command line" >> $cross
if test -e "$source_path/.git" && \
{ test "$targetos" = linux || test "$targetos" = "windows"; }; then
{ test "$host_os" = linux || test "$host_os" = "windows"; }; then
echo 'werror = true' >> $cross
fi
echo "[project options]" >> $cross
Expand Down Expand Up @@ -1752,7 +1752,7 @@ if test "$skip_meson" = no; then
echo "windmc = [$(meson_quote $windmc)]" >> $cross
if test "$cross_compile" = "yes"; then
echo "[host_machine]" >> $cross
echo "system = '$targetos'" >> $cross
echo "system = '$host_os'" >> $cross
case "$cpu" in
i386)
echo "cpu_family = 'x86'" >> $cross
Expand All @@ -1778,8 +1778,8 @@ if test "$skip_meson" = no; then
fi
mv $cross config-meson.cross
meson_add_machine_file config-meson.cross
if test -f "$source_path/configs/meson/$targetos.txt"; then
meson_add_machine_file $source_path/configs/meson/$targetos.txt
if test -f "$source_path/configs/meson/$host_os.txt"; then
meson_add_machine_file $source_path/configs/meson/$host_os.txt
fi

rm -rf meson-private meson-info meson-logs
Expand Down
2 changes: 1 addition & 1 deletion contrib/ivshmem-client/meson.build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
executable('ivshmem-client', files('ivshmem-client.c', 'main.c'), genh,
dependencies: glib,
build_by_default: targetos == 'linux',
build_by_default: host_os == 'linux',
install: false)
2 changes: 1 addition & 1 deletion contrib/ivshmem-server/meson.build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
executable('ivshmem-server', files('ivshmem-server.c', 'main.c'), genh,
dependencies: [qemuutil, rt],
build_by_default: targetos == 'linux',
build_by_default: host_os == 'linux',
install: false)
2 changes: 1 addition & 1 deletion contrib/vhost-user-blk/meson.build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
executable('vhost-user-blk', files('vhost-user-blk.c'),
dependencies: [qemuutil, vhost_user],
build_by_default: targetos == 'linux',
build_by_default: host_os == 'linux',
install: false)
2 changes: 1 addition & 1 deletion contrib/vhost-user-input/meson.build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
executable('vhost-user-input', files('main.c'),
dependencies: [qemuutil, vhost_user],
build_by_default: targetos == 'linux',
build_by_default: host_os == 'linux',
install: false)
2 changes: 1 addition & 1 deletion contrib/vhost-user-scsi/meson.build
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
if libiscsi.found()
executable('vhost-user-scsi', files('vhost-user-scsi.c'),
dependencies: [qemuutil, libiscsi, vhost_user],
build_by_default: targetos == 'linux',
build_by_default: host_os == 'linux',
install: false)
endif
2 changes: 1 addition & 1 deletion docs/devel/kconfig.rst
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,6 @@ variable::

host_kconfig = \
(have_tpm ? ['CONFIG_TPM=y'] : []) + \
(targetos == 'linux' ? ['CONFIG_LINUX=y'] : []) + \
(host_os == 'linux' ? ['CONFIG_LINUX=y'] : []) + \
(have_ivshmem ? ['CONFIG_IVSHMEM=y'] : []) + \
...
2 changes: 1 addition & 1 deletion fsdev/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ fsdev_ss.add(when: ['CONFIG_FSDEV_9P'], if_true: files(
'9p-marshal.c',
'qemu-fsdev.c',
), if_false: files('qemu-fsdev-dummy.c'))
if targetos in ['linux', 'darwin']
if host_os in ['linux', 'darwin']
system_ss.add_all(fsdev_ss)
endif

Expand Down
4 changes: 2 additions & 2 deletions hw/9pfs/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ fs_ss.add(files(
'coth.c',
'coxattr.c',
))
if targetos == 'darwin'
if host_os == 'darwin'
fs_ss.add(files('9p-util-darwin.c'))
elif targetos == 'linux'
elif host_os == 'linux'
fs_ss.add(files('9p-util-linux.c'))
endif
fs_ss.add(when: 'CONFIG_XEN_BUS', if_true: files('xen-9p-backend.c'))
Expand Down
2 changes: 1 addition & 1 deletion hw/display/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ if config_all_devices.has_key('CONFIG_VIRTIO_GPU')
virtio_gpu_ss = ss.source_set()
virtio_gpu_ss.add(when: 'CONFIG_VIRTIO_GPU',
if_true: [files('virtio-gpu-base.c', 'virtio-gpu.c'), pixman])
if targetos == 'linux'
if host_os == 'linux'
virtio_gpu_ss.add(files('virtio-gpu-udmabuf.c'))
else
virtio_gpu_ss.add(files('virtio-gpu-udmabuf-stubs.c'))
Expand Down
2 changes: 1 addition & 1 deletion hw/ppc/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ppc_ss.add(when: ['CONFIG_PSERIES', 'CONFIG_TCG'], if_true: files(
'spapr_softmmu.c',
))
ppc_ss.add(when: 'CONFIG_SPAPR_RNG', if_true: files('spapr_rng.c'))
if targetos == 'linux'
if host_os == 'linux'
ppc_ss.add(when: 'CONFIG_PSERIES', if_true: files(
'spapr_pci_vfio.c',
))
Expand Down
4 changes: 2 additions & 2 deletions hw/usb/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ system_ss.add(when: 'CONFIG_USB_STORAGE_UAS', if_true: files('dev-uas.c'))
system_ss.add(when: 'CONFIG_USB_AUDIO', if_true: files('dev-audio.c'))
system_ss.add(when: 'CONFIG_USB_SERIAL', if_true: files('dev-serial.c'))
system_ss.add(when: 'CONFIG_USB_NETWORK', if_true: files('dev-network.c'))
if targetos != 'windows'
if host_os != 'windows'
system_ss.add(when: 'CONFIG_USB_STORAGE_MTP', if_true: files('dev-mtp.c'))
endif

Expand All @@ -60,7 +60,7 @@ endif

# U2F
system_ss.add(when: 'CONFIG_USB_U2F', if_true: files('u2f.c'))
if targetos == 'linux'
if host_os == 'linux'
system_ss.add(when: 'CONFIG_USB_U2F', if_true: [libudev, files('u2f-passthru.c')])
endif
if u2f.found()
Expand Down
Loading

0 comments on commit d0cda6f

Please sign in to comment.