Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test suite for OutputStream #337

Closed
rvanvelzen opened this issue Oct 29, 2013 · 3 comments · May be fixed by sanjoyroy/UglifyJS2#1
Closed

Create test suite for OutputStream #337

rvanvelzen opened this issue Oct 29, 2013 · 3 comments · May be fixed by sanjoyroy/UglifyJS2#1

Comments

@rvanvelzen
Copy link
Collaborator

The test suite currently present does its work perfectly. However, because it uses the OutputStream to verify equal output. Alas, bugs in the OutputStream are not easily found.

For example, uglifying x = 2 * (a % b / b * c) gives x = 2 * a % b / b * c which is clearly wrong.
mishoo added a commit that referenced this issue Oct 30, 2013
@mishoo
Fix output for x = 2 * (a % b / b * c)
e4c5302 
(issue #337)
@rvanvelzen rvanvelzen mentioned this issue Jan 14, 2015
Closed
@fabiosantoscode
Copy link
Contributor

How about addressing this with an expect_exact: "exact output stream" clause in the current tests? It would result in a pretty minimal change set.

@fabiosantoscode fabiosantoscode mentioned this issue Apr 12, 2015
Closed
@fabiosantoscode
Copy link
Contributor

Lol I was just checking whether it was possible, and a wild pull request-ready changeset appeared :)

@rvanvelzen rvanvelzen mentioned this issue Jul 30, 2015
Closed
@alexlamsl
Copy link
Collaborator

I believe #675 fixed this issue.

@snyk-bot snyk-bot mentioned this issue May 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rvanvelzen @fabiosantoscode @alexlamsl