Doc: "keep_infinity" is redundant on modern Chrome #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that "keep_infinity" compress option is only useful for older versions of Chrome. The initial performance assessment that concluded `Infinity` was faster than `1/0` was based on Chrome 57. mishoo#1723 (comment) Chrome 63 suffers no such degradation. https://jsperf.com/infinity-vs-1-0-v2-0
|
/cc @kzc |
|
Chrome no longer penalizes The default is: No harm keeping the option. |
kzc
reviewed
Jan 7, 2018
| @@ -658,7 +658,7 @@ If you're using the `X-SourceMap` header instead, you can just omit `sourceMap.u | |||
| `Function.prototype.name`. See also: the `keep_fnames` [mangle option](#mangle). | |||
|
|
|||
| - `keep_infinity` (default: `false`) -- Pass `true` to prevent `Infinity` from | |||
| being compressed into `1/0`, which may cause performance issues on Chrome. | |||
| being compressed into `1/0`, which may cause performance issues on old versions of Chrome. | |||
There was a problem hiding this comment.
It would be better to state when Chrome reached performance parity for 1/0 and Infinity. If not the specific version, at least the year.
|
Not that having more options is bad, but does anyone out there actually switches this on? |
|
I noticed @std/esm was using keep_infinity which initially sparked my
curiosity.
https://github.com/standard-things/esm/blob/master/.uglifyrc
…On 7 Jan 2018 5:38 pm, "João Dias" ***@***.***> wrote:
Not that having more options is bad, but does anyone out there actually
switches this on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2743 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGni9bTKzmbyIaZVbjoKAeSWBN3IRWHnks5tIQEJgaJpZM4RVqhb>
.
|
|
They don't even use |
Maintainer of |
alexlamsl
force-pushed
the
master
branch
2 times, most recently
from
7d1c0a7 to
b468103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that "keep_infinity" compress option is only useful for older versions of Chrome.
The initial performance assessment that concluded
Infinitywas faster than1/0was based on Chrome 57.#1723 (comment)
Chrome 63 suffers no such degradation.
https://jsperf.com/infinity-vs-1-0-v2-0