-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmony support #448
Comments
Any comment on this? |
That would be great to have, ES6 brings a lot of important new features but minification of all of them is still needed. |
+1 |
+1 |
👍 |
+1 |
👍 just got bit by |
If harmony support were enabled, we could also safely convert functions that don't use |
+1 -- I'm writing a game for future browsers so I don't want to add the overhead of traceur to my code. I also think converting functions to arrows when |
Adding harmony support on my fork, https://github.com/fabiosantoscode/UglifyJS2/tree/harmony little by little, to later pull request that back to this project. Got arrow functions working so far (I think). |
@fabiosantoscode Awesome! It would be super cool if you could submit separate new language features as separate pull requests. That will make reviewing them a lot easier. :) |
Okay, I'll restructure my commit history to do just that. I'm writing some tests for the parser, and am thinking of doing so for the output as well, is that okay? |
👍 bump. |
👍 |
👍 |
1 similar comment
👍 |
I hope everyone knows how to find technical information about ecmascript 6 / ecmascript 2015 Some examples:
Note: understanding the structure of the spec, instead of reading it may be more important long term, so its easy to find information about specific items of the spec. Good luck |
+1 |
👍 |
@hamosapience you made a typo in the message; it says "depreceted" instead of "deprecated". Also, it directs people to |
Re current README.md currently states
So which npmjs.com source is correct... https://www.npmjs.com/package/uglify-es or https://www.npmjs.com/package/uglify-js ?? e.g. they both point to Thanks for the look. |
@Martii both are correct, uglify-es is the Harmony branch, and uglify-js is the master branch |
@graingert Should be...
... but is currently ...
Cc: @isaacs ... is there a way to have npmjs.com read the harmony branch README.md correctly? Thanks for the visit in advance. |
Documentation for |
Suggestion: Set up Gitter for general discussion if you haven't already, and then put a link in the README to it. |
I'm unable to understand how to correctly integrate uglify-es with the usual ember build pipeline: a few weeks ago I just had to add the dependency "uglify-js": "git://github.com/mishoo/UglifyJS2#harmony" but this not work any more. I tried removing ember-cli-uglify and depending instead by ember-cli-uglify-es but this not seems to work too. Can anyone please give me an hint? |
Note that the api has been changed on harmony because of the breaking changes. This is done as preparation for uglifyJS v3. |
@Polve if you're using webpack@1 and mishoo/UglifyJS2#harmony and have met the uglify-es problem, then you must be in the same trouble as I was. You could try my fork of webpack and re-install, it would help.
This fork is including uglify-js < 3, and can work well. |
uglify-js#harmony was officially renamed to uglify-es, causing this repo not working.
locked to harmony-lagacy branch in version 2.x
I'm not using webpack, and I'm still stuck, unable to create a production build :-( |
I'm not a webpack user, but you could try: |
In comparison Sputnik 1 was pretty much designed in 3 years and launched if Wikipedia isn't lying to me. |
Hey. npm doesn't read the readme.md file from GitHub. It reads the local file at publish time. To change it, publish a new version. |
@isaacs thanks for the confirmation. I believe this has been taken care of in #448 (comment) |
That explains a bit. Thanks. |
Does someone know how to integrate uglify-es in grunt project? |
Sounds like a great question for stack overflow |
@BagMA use the |
Is there an official |
RTFM |
@alexlamsl Since |
@kzc sure thing 👍 |
I'm trying to use the excellent livenode with a project which uses ES6 features introduced in node v11, but unfortunately UglifyJS's parser chokes when it encounters a
let
statement or a generator function (function *() { yield true }
).The text was updated successfully, but these errors were encountered: