prevent ball search from marking playfield active #1610
Conversation
Added ignore_switch_ms to ball search resets to prevent a ball search from cancelling itself because of erroneous switch reads during reset.
|
Makes sense. Got a test case as well? |
|
I do not have a test case. There is an ignore_switch_ms test in drop_targets already, but I am not sure how to incorporate the ball search aspect. |
|
I guess you are solving some issue with this right? Basically, that the switch activation is delayed after the reset, right? We should reproduce the condition in a test to make sure we do not regress this later on. |
|
Yes, how do I call the _ball_search method from drop_targets.py in a test? |
|
OK. I added a test. For each ball search phase, it waits for a drop reset to occur, twiddles the drop reset switch within ignore_switch_ms, and confirms that the state of the target has not changed. The new version of drop_targets.py passes the test and the old version fails. |
|
Awesome. Thanks! |
|
Kudos, SonarCloud Quality Gate passed!
|
Added ignore_switch_ms to ball search resets to prevent a ball search from cancelling itself because of erroneous switch reads during reset.