Auditor checks if events exist before setting to 0 #1619
Conversation
The _load_defaults was setting all events that were configured to 0 when this was called (which happens on every _initiatlize. This changes it to be the same logic as switches and players. It checks if the event is already in the list. If it is not, it creates it and sets it to 0. If it is in the list, it is ignored. This also works for the reset because it blanks the entire list out first, then recreates. So when it does this, all values would be missing, and thus are created with a value of 0.
|
@jabdoa2 The one CI error isn't related to what I touched: build/lib/mpf/core/file_interface.py I can go remove Union from the import, but want to verify first since I didn't touch that file. |
atummons
changed the title
|
Awesome! Thanks! |
Feel free to fix it. Either I broke that by accident or maybe the linter got some update which resulted in new findings. |
|
Kudos, SonarCloud Quality Gate passed!
|
All good to go now! |
The _load_defaults was setting all events that were configured to 0 when
this was called (which happens on every _initiatlize. This changes it
to be the same logic as switches and players. It checks if the event is
already in the list. If it is not, it creates it and sets it to 0. If
it is in the list, it is ignored. This also works for the reset because
it blanks the entire list out first, then recreates. So when it does
this, all values would be missing, and thus are created with a value of
0.