Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a feature to jump to a state of shot profile #1633

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

atummons
Copy link
Contributor

This feature lets a user have a list of events that will jump a shot to a
specific state of its shot profile when fired. This can be done even
when the shot is disabled based on the arguments provided.

This feature lets a user have a lit of events that will jump a shot to a
specific state of its shot profile when fired.  This can be done even
when the shot is disabled based on the arguments provided.
Copy link
Collaborator

@avanwinkle avanwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat stuff!

mpf/devices/shot.py Outdated Show resolved Hide resolved
mpf/devices/shot.py Outdated Show resolved Hide resolved
mpf/devices/shot.py Outdated Show resolved Hide resolved
mpf/config_spec.yaml Outdated Show resolved Hide resolved
Cleanup some unnecessary methods and rename jump_states to
control_events for consistency.
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@avanwinkle avanwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for the new functionality!

@jabdoa2 jabdoa2 merged commit f5a11a7 into missionpinball:dev Mar 24, 2022
@jabdoa2
Copy link
Collaborator

jabdoa2 commented Mar 24, 2022

👍

@atummons atummons deleted the shot_jump_state branch August 31, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants