Fast segment display update hz #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SEG processor does not send responses for PA, PD, PS, and PC messages. Refactor serial communicator to not wait and timeout
default is updates every 0.03 secs (about 30 fps) adjust this in mpf/platforms/fast/fast.py line 350
COMMA!!!!!!!!!!!!
Added / fixed: * HZ update throttling * fixed color settings * FIxed display ordering
Update my branch with latest dev
Merge in latest missionpinball/mpf dev
|
Kudos, SonarCloud Quality Gate passed!
|
jabdoa2
reviewed
May 24, 2022
| self.net_connection.send('WD:' + str(hex(self.config['watchdog']))[2:]) | ||
| except: |
There was a problem hiding this comment.
Why do we ignore all errors here? I am certain that this breaks the linter (which is not currently running in CI).
jabdoa2
reviewed
May 24, 2022
| @@ -268,7 +276,7 @@ def process_received_message(self, msg: str, remote_processor: str): | |||
| self.log.warning("Received malformed message: %s from %s", msg, remote_processor) | |||
| return | |||
|
|
|||
| # Can't use try since it swallows too many errors for now | |||
| # Can't use try since it swallows too many errors for now #TODO | |||
jabdoa2
reviewed
May 24, 2022
|
|
||
| if self.fast_segs: | ||
| self._seg_task = self.machine.clock.schedule_interval(self._update_segs, | ||
| 1 / self.machine.config['fast'][ |
There was a problem hiding this comment.
Invalid indent. Please run a linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the FAST Platform interface so that segment display updates are sent out at a configurable hz rate. Also updates some deprecated modules.