Update text_ui.py #1673
Merged
Update text_ui.py #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts back to where it used to be. This change throws an error (maybe an issue upstream) where various events players will error out. This makes Text_UI have the issue from before where it won't update player variables unless score, ball, or player changes. But better than breaking. At some point I will dig into a real fix to make Text_UI match what is expected for all scenarios.
|
I guess a try catch inside the handler would work around all those issues with non trivial types. |
Per Jan comment, adds try and excepts ValueError (only error I could hit). I just have it passing for now. Could add specific messages to debug log, but its not really an issue, just based on how it is all designed from my view.
Good idea. Put it in, and is working for my local tests. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Awesome. Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts back to where it used to be. This change throws an error (maybe an issue upstream) where various events players will error out. This makes Text_UI have the issue from before where it won't update player variables unless score, ball, or player changes. But better than breaking. At some point I will dig into a real fix to make Text_UI match what is expected for all scenarios.