-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add slim builds for modern browsers #260
Conversation
For the record, in my own app this reduces the total cost of the |
I scaled back the ambition of #258 (#258 (comment)), so now I think this PR stands on its own. Assuming the library consumer has their Babel plugins set up correctly, they can use |
b29198a
to
047093c
Compare
Rebased and fixed merge conflicts |
I'm starting to wonder if it would make more sense to release a new version of emoji-mart with a breaking change, which is to drop support for old browsers (unless you apply Babel transforms yourself to emoji-mart, in which case they are supported). |
I was wondering the same yesterday. Not too sure what’s the current state of affairs in regard to component libraries. Wouldn’t it be ideal to just provide the most modern version of it and people can transpile it with their already-in-place compiling tool of choice. I guess these usually ignore |
@EtienneLem Yeah and we are also already encouraging people to do this to remove the prop-types. How about this:
BTW by "modern" I mean "evergreen browsers, no IE11" 🙂. I could make that clearer in the docs. |
047093c
to
b1be155
Compare
Rebased and tweaked the README a bit |
Managed to get the size down by tweaking the
|
feat: add slim builds for modern browsers
feat: add slim builds for modern browsers
@nolanlawson By moving all these
I noticed your discussion related to evergreen browsers, but it would be nice if this version 2.x could still remain compatible with IE11. Thanks! cc @EtienneLem |
fixes #259
This adds
dist-modern
as proposed in that issue. It also adds some text to theREADME
so that folks know how to use the "slim" build.