fix: fix preact compat #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find, thanks. Sorry for the long delay on PRs, I’ll be reviewing / merging them very soon. |
|
No problem. BTW I just did a bit of extended testing on this, and I think we're still not preact-compatible. There seem to be some bugs with switching categories. Maybe it's best to just put preact compatibility on the back burner, since both inferno and react-lite work. |
|
Roger that. I’m currently working on a Preact project myself, so I don’t mind giving it a go once the other PRs have been sorted out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254
I'm not sure why Preact is subtly different from React, but not caching
this.parentfixes the error. I don't think there's any performance hit for not caching it (container.parentElementshould be a cheap operation), so it seems worth it to get compatibility with Preact.You can test this by using this branch and running the storybook. Before this fix, there's an error in the console; after this fix, there isn't.