fix: improve a11y of skin tone picker #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 13, 2019
…in-dots fix: improve a11y of skin tone picker
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 13, 2019
…in-dots fix: improve a11y of skin tone picker
|
Apparently Preact doesn't like the syntax |
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is a full fix for #294 but it's a bit better than before. When the picker is not expanded, it's a popup button, then when you click it it becomes a toggle button within a menu item within a menu of similar buttons.
I tested this in NVDA and VoiceOver, and it works much better in NVDA than VoiceOver (VoiceOver doesn't seem to notice the toggle state for the buttons, nor the menu). But it's usable in either one.