Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exceptEmojis optional when calling init #785

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Make exceptEmojis optional when calling init #785

merged 2 commits into from
Jan 23, 2023

Conversation

Zertz
Copy link
Contributor

@Zertz Zertz commented Jan 23, 2023

import data from "@emoji-mart/data";
import { init } from "emoji-mart";

init({ data });

Before: TypeError: undefined is not an object (evaluating 'props.exceptEmojis.includes')

After: ✅

@EtienneLem EtienneLem merged commit b9e3feb into missive:main Jan 23, 2023
@EtienneLem
Copy link
Member

Thanks! Made it not use optional chaining, just to make 1000000% sure we avoid trouble with some older Webpack versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants