Some favicons cannot be loaded / saved.

[memo-567]

💡 Summary

Some favicons cannot be loaded / saved.

🥰 Expected Behavior

Favicons should be saved and displayed.

🤬 Actual Behavior

📝 Steps to Reproduce

Logfile:

INFO *	[download]	Downloading https://chaos.social/packs/media/icons/android-chrome-36x36-4c61fdb42936428af85afdbf8c6a45a8.png to /tmp/tmp-1319-3XHancQuPy53 ...
DONE *	[download]	Download finished: https://chaos.social/packs/media/icons/android-chrome-36x36-4c61fdb42936428af85afdbf8c6a45a8.png
ERR  *	[server]	StatusError: Unexpected mime
INFO *	[download]	Downloading https://chaos.social/packs/media/icons/favicon-48x48-c1197e9664ee6476d2715a1c4293bf61.png to /tmp/tmp-1319-GShuvPKd9p70 ...
DONE *	[download]	Download finished: https://chaos.social/packs/media/icons/favicon-48x48-c1197e9664ee6476d2715a1c4293bf61.png
ERR  *	[server]	StatusError: Unexpected mime
INFO *	[metadata]	Fetching metadata of chaos.social ...
INFO *	[metadata]	Fetching nodeinfo of chaos.social ...
INFO *	[metadata]	Fetching HTML of chaos.social ...
DONE *	[metadata]	Successfuly fetched nodeinfo of chaos.social
DONE *	[metadata]	Successfuly fetched metadata of chaos.social
DONE *	[metadata]	Successfuly updated metadata of chaos.social

📌 Environment

Misskey versions: 13.7.5 / 13.8.0 / 13.8.1
Your OS: Debian 11
Your browser: all

[saschanaz]

sharpがICOはサポートしていないせいだと聞きました / I heard this is because sharp does not support ICO format.

[memo-567]

I don't know what this sharp is, but is there a fix for it?

[saschanaz]

ここから発生していますね / It's coming from here:

misskey/packages/backend/src/server/FileServerService.ts

Lines 261 to 275 in 81e6a21

	const isConvertibleImage = isMimeImage(file.mime, 'sharp-convertible-image');
	const isAnimationConvertibleImage = isMimeImage(file.mime, 'sharp-animation-convertible-image');
	if (
	'emoji' in request.query ||
	'avatar' in request.query ||
	'static' in request.query ||
	'preview' in request.query ||
	'badge' in request.query
	) {
	if (!isConvertibleImage) {
	// 画像でないなら404でお茶を濁す
	throw new StatusError('Unexpected mime', 404);
	}
	}

多分ICOファイルはそのまま使っていいかもです。/ I guess it's probably fine to skip conversion for ICO files 🤔

[tamaina]

icoファイルは大変大きいので、クライアントに読ませるのは避けたい

[acid-chicken]

ico 自体のデコードは楽なはず (e.g. https://github.com/image-rs/image/blob/master/src/codecs/ico/decoder.rs) なのでなんとかなってほしい

[memo-567]

This seems mostly affect custom favicons.

As long as it doesn't work properly, I've switched it off for now.

[tamaina]

インスタンスのアイコンにこんなにico突っ込まれてたっけ？

[tamaina]

ico 自体のデコードは楽なはず

実装が簡単とは言わなかったな？

[memo-567]

Yes, it should usually display as shown in the screenshot.

It just doesn't seem to work with custom favicons.
Not even with my Misskey instance's own custom favicon.

[tamaina]

media-proxy v0.0.17で対応した

[tamaina]

本体メディアプロキシはまだ