Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen address を変更可能にする #7738

Closed
mei23 opened this issue Aug 29, 2021 · 5 comments · Fixed by #9924
Closed

Listen address を変更可能にする #7738

mei23 opened this issue Aug 29, 2021 · 5 comments · Fixed by #9924
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR

Comments

@mei23
Copy link
Contributor

mei23 commented Aug 29, 2021

Summary

MisskeyのListen addressは、おそらくNode.js側のデフォルトの::0.0.0.0になっているが、
https://nodejs.org/api/net.html#net_server_listen_port_host_backlog_callback
広すぎる気がするので、デフォルトでは127.0.0.1にして、設定により変更できるようになどする。
→ デフォルトはそのままの方が良いかな

@mei23 mei23 added the ✨Feature This adds/improves/enhances a feature label Aug 29, 2021
@mei23
Copy link
Contributor Author

mei23 commented Aug 29, 2021

Dockerコンテナ内のMisskeyのListen addressの決め方がよくわからない。

@mei23 mei23 added the packages/backend Server side specific issue/PR label Aug 30, 2021
@ledlamp
Copy link
Contributor

ledlamp commented May 14, 2022

Yes, please add a config option for the bind address.
はい、バインドアドレスのコンフィグオプションを追加してください。

@ledlamp
Copy link
Contributor

ledlamp commented May 14, 2022

Dockerコンテナ内のMisskeyのListen addressの決め方がよくわからない。

Docker applications should listen on 0.0.0.0, but native applications should listen on 127.0.0.1.
Dockerアプリケーションは0.0.0.0をリッスンしますが、ネイティブアプリケーションは127.0.0.1をリッスンする必要があります。[deepl]

@ledlamp
Copy link
Contributor

ledlamp commented Feb 13, 2023

fastify.listen({ port: this.config.port, host: '0.0.0.0' });

do fastify.listen({ port: this.config.port, host: this.config.host });.

@ledlamp
Copy link
Contributor

ledlamp commented Feb 13, 2023

Actually, default host should be "::" or empty, so that it listens on both IPv4 and IPv6. If you specify "0.0.0.0", it is not available on IPv6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants