fix: Allow configuring of the host/address to listen/bind to #9924
Conversation
| @@ -30,6 +30,9 @@ url: https://example.tld/ | |||
| # The port that your Misskey server should listen on. | |||
| port: 3000 | |||
|
|
|||
| # The hostname or address to listen on (default: all) | |||
| #host: "127.0.0.1" | |||
There was a problem hiding this comment.
The name "host" has a wide range and can be confusing, so how about "listenHost" or something similar?
There was a problem hiding this comment.
I think it is okay because I can not think of anything else it could mean in this context. It is simple and consistent with the node.js code.
If it's called "listenHost", then should "port" be called "listenPort"?
There was a problem hiding this comment.
Maybe hostname is better? (Oh but there's already host below...)
There was a problem hiding this comment.
When people see the property config.host, they don't know what host it refers to.
then should "port" be called "listenPort"?
I think so.
There was a problem hiding this comment.
what about bind or bindAddress?
There was a problem hiding this comment.
This is a server configuration, so IMO host/port shouldn't be too confusing, especially with the comments here.
There was a problem hiding this comment.
(But then it could be confusing too because below host means the address the server connects to, and here it's to receive connections. Maybe bind is better then.)
|
👍🏻 |
First of all, the default behavior of node.js server is to listen on all addresses of both IPv4 and IPv6. However, Misskey was hard-coded to listen on
"0.0.0.0", which makes node.js listen on IPv4 only.Second, the administrator should be able to configure the host, just like any other server allows you to do. In production, when the server is behind a reverse proxy, it is a good idea to make the backend listen only on a loopback address, so that it is not publicly exposed. There are also other possible reasons, for example, binding to port 80 of an IPv6 address to connect directly to Cloudflare, without conflicting with other web servers on the same system.
So with this PR,
hostcan be configured just likeport, and it defaults toundefinedso node.js listens on both stacks, not just IPv4. Closes #7738