enhance(e2e): more resilient version of visit('/')
#10128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
visitAndWaitにした方がもっと色々使えるかもです🤔 |
Codecov Report
@@ Coverage Diff @@
## develop #10128 +/- ##
========================================
Coverage 25.06% 25.06%
========================================
Files 705 705
Lines 65151 65151
Branches 2307 2307
========================================
Hits 16329 16329
Misses 48822 48822 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やっぱりPR template消えました。
なにを
visitHomeコマンドを追加、なにかボタンが現れるまで待つようにするなんで
ローカルで
pnpm devを対象にテスト回したらバックエンド遅すぎて失敗しますが、ちゃんとページロード終わったのかの確認がないので、エラーメッセージだけ読んだらなんか本当に壊れているように見えるのを何とかしました。