Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): DriveFile related N+1 query when call note packMany (again) #10190

Merged
merged 8 commits into from
Mar 4, 2023

Conversation

rinsuki
Copy link
Contributor

@rinsuki rinsuki commented Mar 3, 2023

retry of #10133

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 3, 2023
@github-actions github-actions bot requested a review from syuilo March 3, 2023 21:40
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #10190 (83fda43) into develop (7e87005) will increase coverage by 0.08%.
The diff coverage is 96.07%.

@@             Coverage Diff             @@
##           develop   #10190      +/-   ##
===========================================
+ Coverage    69.14%   69.22%   +0.08%     
===========================================
  Files          706      706              
  Lines        65312    65359      +47     
  Branches      5181     5204      +23     
===========================================
+ Hits         45159    45248      +89     
+ Misses       20153    20111      -42     
Impacted Files Coverage Δ
...kend/src/core/entities/GalleryPostEntityService.ts 51.66% <0.00%> (-0.88%) ⬇️
...ackend/src/core/entities/DriveFileEntityService.ts 71.18% <100.00%> (+2.24%) ⬆️
...ges/backend/src/core/entities/NoteEntityService.ts 83.25% <100.00%> (+0.88%) ⬆️
packages/backend/src/core/NotificationService.ts 95.71% <0.00%> (-4.29%) ⬇️
packages/backend/src/core/CustomEmojiService.ts 54.45% <0.00%> (+3.66%) ⬆️
packages/backend/src/server/api/endpoints/notes.ts 95.69% <0.00%> (+43.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 49f0837 into develop Mar 4, 2023
@syuilo syuilo deleted the fix/rinsuki/retry-10133 branch March 4, 2023 07:48
@syuilo
Copy link
Member

syuilo commented Mar 4, 2023

🙏🏻🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants