Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: サーバーでメール配信が無効になっている場合は設定ページにその旨を表示する #10191

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

nexryai
Copy link
Contributor

@nexryai nexryai commented Mar 3, 2023

Resolve: #9745
サーバーでメール配信が無効の場合は設定画面に以下のようなメッセージを示すようにしました。


Screenshot from 2023-03-04 07-41-09

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 3, 2023
@github-actions github-actions bot requested review from rinsuki and tamaina March 3, 2023 22:48
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #10191 (5580d39) into develop (6dd9374) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 5580d39 differs from pull request most recent head 5488d4e. Consider uploading reports for the commit 5488d4e to get more accurate results

@@             Coverage Diff             @@
##           develop   #10191      +/-   ##
===========================================
- Coverage    69.23%   69.14%   -0.10%     
===========================================
  Files          707      706       -1     
  Lines        65404    65312      -92     
  Branches      5211     5177      -34     
===========================================
- Hits         45283    45159     -124     
- Misses       20121    20153      +32     
Impacted Files Coverage Δ
packages/backend/src/misc/content-disposition.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/backend/src/server/api/endpoints/notes.ts 52.68% <0.00%> (-43.02%) ⬇️
packages/backend/src/core/CustomEmojiService.ts 50.78% <0.00%> (-3.67%) ⬇️
...ackend/src/core/entities/DriveFileEntityService.ts 68.93% <0.00%> (-2.25%) ⬇️
...ges/backend/src/core/entities/NoteEntityService.ts 82.36% <0.00%> (-0.89%) ⬇️
packages/backend/src/core/DownloadService.ts 71.53% <0.00%> (-0.09%) ⬇️
packages/backend/src/misc/correct-filename.ts
packages/backend/src/core/DriveService.ts 57.14% <0.00%> (+0.05%) ⬆️
packages/backend/src/server/FileServerService.ts 19.56% <0.00%> (+0.68%) ⬆️
...kend/src/core/entities/GalleryPostEntityService.ts 52.54% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo
Copy link
Member

syuilo commented Mar 4, 2023

サーバーでメール配信無効にしていたとしても、ユーザーのメールアドレスは登録できるようにしておきたい

@nexryai
Copy link
Contributor Author

nexryai commented Mar 4, 2023

登録自体は塞がずに、確認メールを送信しましたのメッセージと「お知らせを配信する」関係の設定を非表示にする方向で調整してみます

@syuilo
Copy link
Member

syuilo commented Mar 4, 2023

あー、メール配信無効だと確認メール送信できないからメール登録自体もできないのか

@syuilo syuilo merged commit 72b3154 into misskey-dev:develop Mar 4, 2023
@syuilo
Copy link
Member

syuilo commented Mar 4, 2023

🙏

yu256 pushed a commit to yu256/akatsukey that referenced this pull request Mar 5, 2023
…ge indicate this (misskey-dev#10191)

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

メール配信が無効のインスタンスでもメール通知の設定が表示されてしまう。
2 participants