Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): cannot build docker image on some environments #10220

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

acid-chicken
Copy link
Member

Docker のデーモンが立っている環境によっては find //proc を触ってしまい find: '/proc/1/map_files': Operation not permitted が出て Docker イメージがビルドできない問題を修正

Since #9568 (comment)

@acid-chicken acid-chicken requested a review from rinsuki March 5, 2023 12:36
@github-actions github-actions bot requested a review from tamaina March 5, 2023 12:36
@acid-chicken acid-chicken added the 🐛Bug Unexpected behavior label Mar 5, 2023
Copy link
Contributor

@rinsuki rinsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このPRはこのPRでいいんだけど、/sysとかも見なくて気がするしそもそも全探索どうにかしたい感はある

@acid-chicken
Copy link
Member Author

find /bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/local/sbin でいい説

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #10220 (7219d0e) into develop (d6d0b96) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10220   +/-   ##
========================================
  Coverage    69.23%   69.23%           
========================================
  Files          707      707           
  Lines        65407    65407           
  Branches      5215     5212    -3     
========================================
+ Hits         45283    45286    +3     
+ Misses       20124    20121    -3     
Impacted Files Coverage Δ
packages/backend/src/core/NotificationService.ts 100.00% <0.00%> (+4.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit b1c173e into develop Mar 5, 2023
@syuilo syuilo deleted the acid-chicken-patch-2 branch March 5, 2023 13:00
@syuilo
Copy link
Member

syuilo commented Mar 5, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants