Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ユーザーページのバッジ表示を適切に折り返すように #10222

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

arrow2nd
Copy link
Contributor

@arrow2nd arrow2nd commented Mar 5, 2023

What

ユーザーページのバッジ表示を画面幅に合わせて適切に折り返すようにしました。

Why

バッジの数が多いユーザーの場合、バッジが途中で折り返されてしまい見づらくなっているから。

関連する issue : #10219

Additional info (optional)

修正箇所のプレビュー

スマホ

Before

mobile

After

fixed_mobile

デスクトップ

Before

desktop

After

fixed_desktop

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 5, 2023
@github-actions github-actions bot requested review from acid-chicken and rinsuki March 5, 2023 12:46
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #10222 (67208c5) into develop (8e8c2b4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10222   +/-   ##
========================================
  Coverage    69.23%   69.23%           
========================================
  Files          707      707           
  Lines        65407    65407           
  Branches      5211     5214    +3     
========================================
+ Hits         45283    45286    +3     
+ Misses       20124    20121    -3     
Impacted Files Coverage Δ
packages/backend/src/core/NotificationService.ts 100.00% <0.00%> (+4.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 8c9c89a into misskey-dev:develop Mar 5, 2023
@syuilo
Copy link
Member

syuilo commented Mar 5, 2023

🙏

@arrow2nd arrow2nd deleted the fix-user-role-display branch March 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants