Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): alsoKnownAsの誤った定義を修正 #10725

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix(backend): alsoKnownAsの誤った定義を修正 #10725

merged 1 commit into from
Apr 29, 2023

Conversation

okayurisotto
Copy link
Contributor

What

このPRは #10724 を修正することを目的としたものです。配列を定義するオブジェクトではformatパラメータが使えないにも関わらず使われている問題を修正します。これは同時に、未定義だった配列の要素の型を定義することでもあります。

Why

現時点ではこれにより不具合が発生しているということはないと思われますが、定義が不十分なことは将来的に問題となってくるだろうと考えます。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #10725 (018749e) into develop (5124db5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #10725   +/-   ##
========================================
  Coverage    76.08%   76.08%           
========================================
  Files          898      898           
  Lines        88742    88747    +5     
  Branches      6268     6266    -2     
========================================
+ Hits         67517    67522    +5     
  Misses       21225    21225           
Impacted Files Coverage Δ
packages/backend/src/models/json-schema/user.ts 100.00% <100.00%> (ø)

@tamaina
Copy link
Contributor

tamaina commented Apr 27, 2023

一応 #10592 には含まれておる

@okayurisotto
Copy link
Contributor Author

あ、本当ですね。この問題の修正も同時に行われているのは確認不足でした。そちらのPRがマージされ次第このPRはクローズします。すみませんでした。

@syuilo
Copy link
Member

syuilo commented Apr 29, 2023

ないとは思うけど10592がマージされる可能性が100%ではないのでとりあえずマージ

@syuilo syuilo merged commit e2d9c0e into misskey-dev:develop Apr 29, 2023
@syuilo
Copy link
Member

syuilo commented Apr 29, 2023

🙏

@okayurisotto okayurisotto deleted the #10724 branch May 2, 2023 12:29
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants