Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: サーバーメトリクスが90度傾いている #11012

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

noridev
Copy link
Contributor

@noridev noridev commented Jun 14, 2023

Fix #11011

What

サーバーメトリクスグラフが90度傾いている問題を修正し、グラフアニメーションが表示されない問題を修正する

Why

#11011
同じ理由でグラフのアニメーションも欠落している

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 14, 2023
@github-actions github-actions bot requested review from syuilo and tamaina June 14, 2023 12:52
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #11012 (92c2a5d) into develop (f5dfb64) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #11012   +/-   ##
========================================
  Coverage    77.47%   77.47%           
========================================
  Files          909      909           
  Lines        91516    91516           
  Branches      6890     6891    +1     
========================================
+ Hits         70904    70906    +2     
+ Misses       20612    20610    -2     

see 1 file with indirect coverage changes

acid-chicken
acid-chicken previously approved these changes Jun 14, 2023
Copy link
Member

@acid-chicken acid-chicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コミット履歴見たら確かにバグだった

@acid-chicken acid-chicken dismissed their stale review June 14, 2023 12:57

rebase してください

@noridev noridev force-pushed the fix-server-metric-pie branch from f2ea7f8 to 92c2a5d Compare June 14, 2023 14:40
@noridev
Copy link
Contributor Author

noridev commented Jun 14, 2023

コミット履歴見たら確かにバグだった

何か変でした。rebase完了しました!

@syuilo syuilo merged commit 8c7bcdf into misskey-dev:develop Jun 17, 2023
@syuilo
Copy link
Member

syuilo commented Jun 17, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

サーバーメトリクスが90度傾いている
3 participants