Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): replace rndstr with secureRndstr #11044

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Conversation

saschanaz
Copy link
Member

What

タイトル通り

Why

もうつかっているものあるし、 #10938 の問題もあるので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Jun 25, 2023
@github-actions github-actions bot requested review from EbiseLutica and syuilo June 25, 2023 01:31
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #11044 (1ee0b9e) into develop (7bb8c71) will decrease coverage by 0.01%.
The diff coverage is 53.33%.

@@             Coverage Diff             @@
##           develop   #11044      +/-   ##
===========================================
- Coverage    77.43%   77.43%   -0.01%     
===========================================
  Files          907      907              
  Lines        91359    91356       -3     
  Branches      6885     6884       -1     
===========================================
- Hits         70744    70740       -4     
- Misses       20615    20616       +1     
Impacted Files Coverage Δ
...ackend/src/server/api/endpoints/admin/emoji/add.ts 72.94% <ø> (-0.32%) ⬇️
...ges/backend/src/server/api/endpoints/app/create.ts 67.14% <0.00%> (ø)
...es/backend/src/server/api/endpoints/auth/accept.ts 54.83% <0.00%> (ø)
...ckend/src/server/api/endpoints/miauth/gen-token.ts 68.42% <0.00%> (ø)
...ackages/backend/src/server/api/endpoints/invite.ts 76.66% <33.33%> (+1.25%) ⬆️
...d/src/server/api/endpoints/admin/reset-password.ts 65.75% <50.00%> (ø)
...backend/src/server/api/endpoints/i/update-email.ts 59.29% <50.00%> (ø)
...ackages/backend/src/server/api/SignupApiService.ts 49.09% <57.14%> (ø)
...src/server/api/endpoints/request-reset-password.ts 61.45% <66.66%> (ø)
...ges/backend/src/misc/generate-native-user-token.ts 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@syuilo syuilo merged commit ef354e9 into develop Jun 25, 2023
@syuilo syuilo deleted the replace-rndstr branch June 25, 2023 02:04
@syuilo
Copy link
Member

syuilo commented Jun 25, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants