Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add suuport Japanese message of errors. #11159

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

sasagar
Copy link
Contributor

@sasagar sasagar commented Jul 7, 2023

What

#11133 の対応

Why

日本語でエラー文が流れた際にRedisに大量にDelayedが蓄積され、適切にDelayedになっているものとの混在で混乱を招くため。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #11159 (ed055e0) into develop (f76b3ed) will increase coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11159      +/-   ##
===========================================
+ Coverage    77.36%   77.93%   +0.57%     
===========================================
  Files          908      172     -736     
  Lines        91662    21617   -70045     
  Branches      7551      496    -7055     
===========================================
- Hits         70916    16848   -54068     
+ Misses       20746     4769   -15977     

see 744 files with indirect coverage changes

@sasagar sasagar requested a review from mei23 July 8, 2023 10:40
@syuilo syuilo merged commit 246d167 into misskey-dev:develop Jul 8, 2023
15 of 16 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 8, 2023

@sasagar @mei23 🙏

@sasagar sasagar deleted the feature/redis-jp-error-support branch July 8, 2023 12:11
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* fix: add suuport Japanese message of errors.

* fix: change catching function.

* lint

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants