Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

現在閲覧中のURLを取得するプロパティを追加 #11234

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

setaria430
Copy link
Contributor

What

windows.location.hrefをAiScriptから呼べるようにした
これにより、ウィジェット・プラグイン開発者が現在のURLを取得できるようになった

Why

AiScriptでURLを条件分岐に含めたい場面が多かったため

  • チャンネル投稿を公開タイムラインに誤爆する人が非常に多いため、チャンネルページに居る時にノート投稿時に確認ダイアログを出したいが、従前の仕様では今居るページがチャンネルかどうか分からない

チャンネルのみならず、アンテナやリスト、あるいは特定の画面IDを含むページでも同様の分岐処理を行いたい

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 10, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 10, 2023 10:20
@setaria430 setaria430 changed the title Origin/current url 現在閲覧中のURLを取得するプロパティを追加 #11232 Jul 10, 2023
@setaria430 setaria430 changed the title 現在閲覧中のURLを取得するプロパティを追加 #11232 現在閲覧中のURLを取得するプロパティを追加 Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #11234 (a82b1e0) into develop (f4d1fca) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11234      +/-   ##
===========================================
+ Coverage    77.67%   77.71%   +0.04%     
===========================================
  Files          908      171     -737     
  Lines        91787    21554   -70233     
  Branches      7671      496    -7175     
===========================================
- Hits         71296    16751   -54545     
+ Misses       20491     4803   -15688     

see 737 files with indirect coverage changes

@syuilo syuilo merged commit c13fd42 into misskey-dev:develop Jul 13, 2023
16 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 13, 2023

👍

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* 現在閲覧中のURLを取得するプロパティを追加 misskey-dev#11232

* commit the uncommitted remainder

---------

Co-authored-by: setaria <v.setaria@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants